linux-kernel - Re: [PATCH] mm/kasan: switch from strlcpy to strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+fCnZdSS9RojAAeF-tNT6jsFtUm34C1Khpsqz0N=4duDe+bqQ@mail.gmail.com>
Date:   Wed, 24 Feb 2021 16:36:41 +0100
From:   Andrey Konovalov <andreyknvl@...il.com>
To:     Zhiyuan Dai <daizhiyuan@...tium.com.cn>
Cc:     Andrey Ryabinin <ryabinin.a.a@...il.com>,
        Dmitriy Vyukov <dvyukov@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Alexander Potapenko <glider@...gle.com>
Subject: Re: [PATCH] mm/kasan: switch from strlcpy to strscpy

On Mon, Feb 22, 2021 at 8:45 AM Alexander Potapenko <glider@...gle.com> wrote:
>
> On Mon, Feb 22, 2021 at 6:10 AM Zhiyuan Dai <daizhiyuan@...tium.com.cn> wrote:
> >
> > strlcpy is marked as deprecated in Documentation/process/deprecated.rst,
> > and there is no functional difference when the caller expects truncation
> > (when not checking the return value). strscpy is relatively better as it
> > also avoids scanning the whole source string.
>
> Looks like a good thing to do.
>
> > Signed-off-by: Zhiyuan Dai <daizhiyuan@...tium.com.cn>
> Acked-by: Alexander Potapenko <glider@...gle.com>
>
> > ---
> >  mm/kasan/report_generic.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/kasan/report_generic.c b/mm/kasan/report_generic.c
> > index 8a9c889..fc7f7ad 100644
> > --- a/mm/kasan/report_generic.c
> > +++ b/mm/kasan/report_generic.c
> > @@ -148,7 +148,7 @@ static bool __must_check tokenize_frame_descr(const char **frame_descr,
> >                 }
> >
> >                 /* Copy token (+ 1 byte for '\0'). */
> > -               strlcpy(token, *frame_descr, tok_len + 1);
> > +               strscpy(token, *frame_descr, tok_len + 1);
> >         }
> >
> >         /* Advance frame_descr past separator. */
> > --
> > 1.8.3.1
> >

Reviewed-by: Andrey Konovalov <andreyknvl@...il.com>

Thanks!