linux-kernel - Re: [PATCH] init/Kconfig: make COMPILE_TEST depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa9d393d-1bc3-fc08-52dd-88e76ead97af@metux.net>
Date:   Wed, 24 Feb 2021 16:58:22 +0100
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     Masahiro Yamada <masahiroy@...nel.org>,
        Heiko Carstens <hca@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>,
        Arnd Bergmann <arnd@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Johannes Weiner <hannes@...xchg.org>,
        KP Singh <kpsingh@...gle.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Terrell <terrelln@...com>,
        Quentin Perret <qperret@...gle.com>,
        Valentin Schneider <valentin.schneider@....com>
Subject: Re: [PATCH] init/Kconfig: make COMPILE_TEST depend on HAS_IOMEM

On 24.02.21 15:08, Masahiro Yamada wrote:
> I read the commit log of the following two:
> 
> - bc083a64b6c0 ("init/Kconfig: make COMPILE_TEST depend on !UML")
> - 334ef6ed06fa ("init/Kconfig: make COMPILE_TEST depend on !S390")
> 
> Both are talking about HAS_IOMEM dependency missing in many drivers.
> 
> So, 'depends on HAS_IOMEM' seems the direct, sensible solution to me.

I don't like idea of hidden indirect dependencies. If a driver needs
iomem, then it should depend on it. Yes, a lot of drivers might need
to be fixed, but IMHO we should do that, instead of covering 'em up.


--mtx

-- 
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287