linux-kernel - Re: [PATCH 2/9] tpm: Allow PCR 23 to be restricted to kernel-only use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YDaJFOv6A8i2oU9D@kernel.org>
Date:   Wed, 24 Feb 2021 19:12:52 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Matthew Garrett <matthewgarrett@...gle.com>
Cc:     linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org,
        linux-pm@...r.kernel.org, keyrings@...r.kernel.org,
        zohar@...ux.ibm.com, jejb@...ux.ibm.com, corbet@....net,
        rjw@...ysocki.net, Matthew Garrett <mjg59@...gle.com>
Subject: Re: [PATCH 2/9] tpm: Allow PCR 23 to be restricted to kernel-only use

On Sat, Feb 20, 2021 at 01:32:48AM +0000, Matthew Garrett wrote:
> +#define TPM_RESTRICTED_PCR 23

As stupid it may sound, I'd just change this to:

#define TPM_PCR_23 23

It documents to the code that we are dealing with PCR 23, which just a
plain number doesn't. By naming it as TPM_RESTRICED_TPM you have to
unnecessarily xref to its definition. It obfuscates rather than clarifies
anything important.

/Jarkko