linux-kernel - Re: Please apply "xen-netback: delete NAPI instance when queue fails to initialize" to v4.4.y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YDaLBcj5DJrSWXqU@kroah.com>
Date:   Wed, 24 Feb 2021 18:21:09 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     SeongJae Park <sjpark@...zon.com>
Cc:     sashal@...nel.org, aams@...zon.com, markubo@...zon.com,
        linux-kernel@...r.kernel.org,
        "# 4 . 4 . y" <stable@...r.kernel.org>,
        David Vrabel <david.vrabel@...rix.com>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: Please apply "xen-netback: delete NAPI instance when queue fails
 to initialize" to v4.4.y

On Wed, Feb 24, 2021 at 06:03:56PM +0100, SeongJae Park wrote:
> This is a request for merge of upstream commit 4a658527271b ("xen-netback:
> delete NAPI instance when queue fails to initialize") on v4.4.y tree.
> 
> If 'xenvif_connect()' fails after successful 'netif_napi_add()', the napi is
> not cleaned up.  Because 'create_queues()' frees the queues in its error
> handling code, if the 'xenvif_free()' is called for the vif, use-after-free
> occurs. The upstream commit fixes the problem by cleaning up the napi in the
> 'xenvif_connect()'.
> 
> Attaching the original patch below for your convenience.

The original patch does not apply cleanly.

> Tested-by: Markus Boehme <markubo@...zon.de>

What was tested?

I backported the patch, but next time, please provide the patch that
will work properly.

greg k-h