linux-kernel - Re: [PATCH] Input: Add "Share" button to Microsoft Xbox One controller.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YDcoduCkBjC8EM3F@google.com>
Date:   Wed, 24 Feb 2021 20:32:54 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Chris Ye <lzye@...gle.com>
Cc:     Chris Ye <linzhao.ye@...il.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, trivial@...nel.org,
        kernel-team@...roid.com
Subject: Re: [PATCH] Input: Add "Share" button to Microsoft Xbox One
 controller.

Hi Chris,

On Thu, Feb 25, 2021 at 04:00:32AM +0000, Chris Ye wrote:
> Add "Share" button input capability and input event mapping for
> Microsoft Xbox One controller.
> Fixed Microsoft Xbox One controller share button not working under USB
> connection.
> 
> Signed-off-by: Chris Ye <lzye@...gle.com>
> ---
>  drivers/input/joystick/xpad.c | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 9f0d07dcbf06..08c3e93ccb2f 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -368,6 +368,14 @@ static const signed short xpad360_btn[] = {  /* buttons for x360 controller */
>  	-1
>  };
>  
> +static const signed short xpad_xboxone_btn[] = {
> +	/* buttons for xbox one controller */
> +	BTN_TL, BTN_TR,		/* Button LB/RB */
> +	BTN_MODE,		/* The big X button */
> +	KEY_RECORD,		/* The share button */

If I understand this correctly, not all Xbox One controllers have this
new key. Is it possible to determine if it is present and only set
capability for controllers that actually have it?

Also, I am unsure if KEY_RECORD is the best keycode for this. It might,
but does your controller supports bluetooth? What HID usage code does it
send for this key?

Thanks.

-- 
Dmitry