linux-kernel - Re: [PATCH v2 4/4] arm64: dts: qcom: sc7180: trogdor: Use ADC TM channel 0 instead of 1 for charger temperature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <161429293348.1254594.17006777195039771186@swboyd.mtv.corp.google.com>
Date:   Thu, 25 Feb 2021 14:42:13 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Rob Herring <robh+dt@...nel.org>
Cc:     devicetree@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Matthias Kaehlcke <mka@...omium.org>
Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: sc7180: trogdor: Use ADC TM channel 0 instead of 1 for charger temperature

Quoting Matthias Kaehlcke (2021-02-25 10:33:37)
> On trogdor the ADC thermal monitor is used for monitoring certain
> device temperatures. All trogdor boards have at least a thermistor
> for the charger temperature, optionally they may have others.
> 
> Currently the ADC thermal monitor is configured to use channel 1
> for the charger temperature. Given that all trogdor boards have
> the charger thermistor it makes more sense to use channel 0,
> and then let boards with other thermistors use channels 1, 2, 3,
> rather than 0, 2, 3.
> 
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@...omium.org>

> 
> Changes in v2:
> - patch added to the series
> 
>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index ab4efaece5cb..58e127b6ba1e 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -19,7 +19,7 @@ charger_thermal: charger-thermal {
>                         polling-delay-passive = <0>;
>                         polling-delay = <0>;
>  
> -                       thermal-sensors = <&pm6150_adc_tm 1>;
> +                       thermal-sensors = <&pm6150_adc_tm 0>;

Too bad this can't point at the sensor "config" node itself. Looks error prone!

>  
>                         trips {
>                                 charger-crit {
> @@ -718,8 +718,8 @@ charger-thermistor@4f {
>  &pm6150_adc_tm {
>         status = "okay";
>  
> -       charger-thermistor@1 {
> -               reg = <1>;
> +       charger-thermistor@0 {
> +               reg = <0>;
>                 io-channels = <&pm6150_adc ADC5_AMUX_THM3_100K_PU>;
>                 qcom,ratiometric;
>                 qcom,hw-settle-time-us = <200>;