linux-kernel - Re: [PATCH v5 2/9] ALSA: virtio: add virtio sound driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h5z2gqvls.wl-tiwai@suse.de>
Date:   Thu, 25 Feb 2021 11:39:59 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Anton Yakovlev <anton.yakovlev@...nsynergy.com>
Cc:     <virtualization@...ts.linux-foundation.org>,
        <alsa-devel@...a-project.org>, <virtio-dev@...ts.oasis-open.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Jason Wang <jasowang@...hat.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 2/9] ALSA: virtio: add virtio sound driver

On Thu, 25 Feb 2021 11:38:35 +0100,
Takashi Iwai wrote:
> 
> On Mon, 22 Feb 2021 16:34:37 +0100,
> Anton Yakovlev wrote:
> > +static int virtsnd_find_vqs(struct virtio_snd *snd)
> > +{
> > +	struct virtio_device *vdev = snd->vdev;
> > +	vq_callback_t *callbacks[VIRTIO_SND_VQ_MAX] = {
> > +		[VIRTIO_SND_VQ_EVENT] = virtsnd_event_notify_cb
> > +	};
> > +	const char *names[VIRTIO_SND_VQ_MAX] = {
> 
> Shouldn't be static?

Also callbacks[] should be static (and maybe const), I suppose.


Takashi