linux-kernel - [PATCH] Input: i8042: Remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210225092943.657-1-angkery@163.com>
Date:   Thu, 25 Feb 2021 17:29:43 +0800
From:   angkery <angkery@....com>
To:     dmitry.torokhov@...il.com, hdegoede@...hat.com, rajatja@...gle.com,
        luomeng12@...wei.com, gustavoars@...nel.org
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Junlin Yang <yangjunlin@...ong.com>
Subject: [PATCH] Input: i8042: Remove unneeded variable

From: Junlin Yang <yangjunlin@...ong.com>

The variable "delay" is initialized to zero and then returned.
So remove the delay variable and return zero.

Generated by:scripts/coccinelle/misc/returnvar.cocci

Signed-off-by: Junlin Yang <yangjunlin@...ong.com>
---
 drivers/input/serio/i8042.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index abae23a..145bda1 100644
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -1126,7 +1126,6 @@ static void i8042_controller_reset(bool s2r_wants_reset)
 
 static long i8042_panic_blink(int state)
 {
-	long delay = 0;
 	char led;
 
 	led = (state) ? 0x01 | 0x04 : 0;
@@ -1142,7 +1141,7 @@ static long i8042_panic_blink(int state)
 	dbg("%02x -> i8042 (panic blink)\n", led);
 	i8042_write_data(led);
 	DELAY;
-	return delay;
+	return 0;
 }
 
 #undef DELAY
-- 
1.9.1