linux-kernel - Re: [PATCH v1] ACPI: processor: idle: Drop extra prefix from pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e70654da-0593-c238-e600-f9be41cc68c8@huawei.com>
Date:   Thu, 25 Feb 2021 22:18:42 +0800
From:   Hanjun Guo <guohanjun@...wei.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux ACPI <linux-acpi@...r.kernel.org>
CC:     LKML <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v1] ACPI: processor: idle: Drop extra prefix from
 pr_notice()

On 2021/2/25 2:37, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Drop "ACPI: " from the pr_noitice() instance in
> acpi_processor_cstate_first_run_checks(), because pr_fmt() causes
> that prefix to be added to the message already.
> 
> Reported-by: Hanjun Guo <guohanjun@...wei.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>   drivers/acpi/processor_idle.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-pm/drivers/acpi/processor_idle.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/processor_idle.c
> +++ linux-pm/drivers/acpi/processor_idle.c
> @@ -780,8 +780,8 @@ static inline void acpi_processor_cstate
>   	dmi_check_system(processor_power_dmi_table);
>   	max_cstate = acpi_processor_cstate_check(max_cstate);
>   	if (max_cstate < ACPI_C_STATES_MAX)
> -		pr_notice("ACPI: processor limited to max C-state %d\n",
> -			  max_cstate);
> +		pr_notice("processor limited to max C-state %d\n", max_cstate);
> +
>   	first_run++;
>   
>   	if (nocst)

Reviewed-by: Hanjun Guo <guohanjun@...wei.com>

Thanks
Hanjun