linux-kernel - Re: [PATCH] RDMA/hw/hfi1/tid_rdma: remove unnecessary conversion to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aeaa298a-8e62-4f0a-c0fe-72cec3c1ed90@talpey.com>
Date:   Thu, 25 Feb 2021 09:24:23 -0500
From:   Tom Talpey <tom@...pey.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        mike.marciniszyn@...nelisnetworks.com
Cc:     dennis.dalessandro@...nelisnetworks.com, dledford@...hat.com,
        jgg@...pe.ca, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/hw/hfi1/tid_rdma: remove unnecessary conversion to
 bool

On 2/25/2021 4:26 AM, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
> 
> ./drivers/infiniband/hw/hfi1/tid_rdma.c:1118:36-41: WARNING: conversion
> to bool not needed here.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>   drivers/infiniband/hw/hfi1/tid_rdma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hfi1/tid_rdma.c b/drivers/infiniband/hw/hfi1/tid_rdma.c
> index 0b1f9e4..8958ea3 100644
> --- a/drivers/infiniband/hw/hfi1/tid_rdma.c
> +++ b/drivers/infiniband/hw/hfi1/tid_rdma.c
> @@ -1115,7 +1115,7 @@ static u32 kern_find_pages(struct tid_rdma_flow *flow,
>   	}
>   
>   	flow->length = flow->req->seg_len - length;
> -	*last = req->isge == ss->num_sge ? false : true;
> +	*last = req->isge == !ss->num_sge;

Are you sure this is what you want? The new code seems to compare
an index to a bool (refactoring)

	*last = req->isge == (ss->num_sge != 0);

Don't you actually want

	*last = req->isge != ss->num_sge;

??

Even then, it seems really hard to read.

>   	return i;
>   }
>   
>