lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGETcx8AYjq7jdGhNXZffg2Y_Jxn3RszuBeXJsRH8on8TC0A-g@mail.gmail.com> Date: Thu, 25 Feb 2021 08:21:19 -0800 From: Saravana Kannan <saravanak@...gle.com> To: Geert Uytterhoeven <geert@...ux-m68k.org> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Bartosz Golaszewski <bgolaszewski@...libre.com>, "Rafael J . Wysocki" <rafael@...nel.org>, Kevin Hilman <khilman@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>, Magnus Damm <magnus.damm@...il.com>, Linux-Renesas <linux-renesas-soc@...r.kernel.org>, Linux PM <linux-pm@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] staging: board: Fix uninitialized spinlock when attaching genpd On Thu, Feb 25, 2021 at 1:25 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote: > > Hi Saravana, > > On Mon, Feb 15, 2021 at 10:03 PM Saravana Kannan <saravanak@...gle.com> wrote: > > On Mon, Feb 15, 2021 at 11:10 AM Geert Uytterhoeven > > <geert@...ux-m68k.org> wrote: > > > On Mon, Feb 15, 2021 at 7:37 PM Saravana Kannan <saravanak@...gle.com> wrote: > > > > On Mon, Feb 15, 2021 at 7:14 AM Geert Uytterhoeven > > > > > @@ -148,7 +149,11 @@ static int board_staging_add_dev_domain(struct platform_device *pdev, > > > > > pd_args.np = np; > > > > > pd_args.args_count = 0; > > > > > > > > > > - return of_genpd_add_device(&pd_args, &pdev->dev); > > > > > + /* Cfr. device_pm_init_common() */ > > > > > > > > What's Cfr? > > > > > > "compare to" (from Latin "confer"). > > > > Can you please change this to "refer to" or "similar to"? Also, not > > sure if this comment is even adding anything useful even if you switch > > the words. > > I changed it to "Initialization similar to device_pm_init_common()" > > > Also, device_pm_init_common() is used in two places outside of > > drivers/base/ with this change. Maybe better to move it to > > linux/device.h? > > arch/sh/drivers/platform_early.c has a separate definition, and this > is intentional, cfr. commit 507fd01d53333387 ("drivers: move the early > platform device support to arch/sh"): > > In order not to export internal drivers/base functions to arch code for > this temporary solution - copy the two needed routines for driver > matching from drivers/base/platform.c to arch/sh/drivers/platform_early.c. > Thanks. The comments and decision to copy the code sounds okay to me. But I'll still leave the Ack/Review to Rafael or someone else as I'm not too familiar with the intent of this flag. -Saravana
Powered by blists - more mailing lists