linux-kernel - Re: [PATCH 06/12] pinctrl: add a pincontrol driver for BCM6362

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Feb 2021 02:41:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Álvaro Fernández Rojas <noltari@...il.com>,
        f.fainelli@...il.com, Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Jonas Gorski <jonas.gorski@...il.com>,
        Necip Fazil Yildiran <fazilyildiran@...il.com>,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org
Subject: Re: [PATCH 06/12] pinctrl: add a pincontrol driver for BCM6362

Hi "Álvaro,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on pinctrl/devel]
[also build test WARNING on v5.11 next-20210225]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/lvaro-Fern-ndez-Rojas/pinctrl-add-BCM63XX-pincontrol-support/20210226-004852
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/94439d611efa703b016c515bd904f5a2f266e221
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review lvaro-Fern-ndez-Rojas/pinctrl-add-BCM63XX-pincontrol-support/20210226-004852
        git checkout 94439d611efa703b016c515bd904f5a2f266e221
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/pinctrl/bcm/pinctrl-bcm6362.c: In function 'bcm6362_set_gpio':
>> drivers/pinctrl/bcm/pinctrl-bcm6362.c:626:8: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     626 |        (unsigned int) desc->drv_data, 0);
         |        ^

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for FRAME_POINTER
   Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS
   Selected by
   - FAULT_INJECTION_STACKTRACE_FILTER && FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT && !X86_64 && !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86


vim +626 drivers/pinctrl/bcm/pinctrl-bcm6362.c

   618	
   619	static void bcm6362_set_gpio(struct bcm6362_pinctrl *pc, unsigned pin)
   620	{
   621		const struct pinctrl_pin_desc *desc = &bcm6362_pins[pin];
   622		unsigned int mask = bcm6362_bank_pin(pin);
   623	
   624		if (desc->drv_data)
   625			regmap_update_bits(pc->regs, BCM6362_BASEMODE_REG,
 > 626					   (unsigned int) desc->drv_data, 0);
   627	
   628		if (pin < PINS_PER_BANK) {
   629			/* base mode 0 => gpio 1 => mux function */
   630			regmap_update_bits(pc->regs, BCM6362_MODE_REG, mask, 0);
   631	
   632			/* pins 0-23 might be muxed to led */
   633			if (pin < BCM6362_NUM_LEDS)
   634				regmap_update_bits(pc->regs, BCM6362_LED_REG, mask, 0);
   635		} else {
   636			/* ctrl reg 0 => wifi function 1 => gpio */
   637			regmap_update_bits(pc->regs, BCM6362_CTRL_REG, mask, mask);
   638		}
   639	}
   640	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (63592 bytes)