linux-kernel - Re: [PATCH v2 1/1] KVM: x86: remove misplaced comment on active_mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <78662af6-be71-4a81-8999-5b7011682728@redhat.com>
Date:   Fri, 26 Feb 2021 09:03:36 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Dongli Zhang <dongli.zhang@...cle.com>, kvm@...r.kernel.org,
        x86@...nel.org
Cc:     seanjc@...gle.com, vkuznets@...hat.com, wanpengli@...cent.com,
        jmattson@...gle.com, joro@...tes.org, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, hpa@...or.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] KVM: x86: remove misplaced comment on
 active_mmu_pages

On 26/02/21 07:19, Dongli Zhang wrote:
> The 'mmu_page_hash' is used as hash table while 'active_mmu_pages' is a
> list. Remove the misplaced comment as it's mostly stating the obvious
> anyways.
> 
> Signed-off-by: Dongli Zhang <dongli.zhang@...cle.com>
> Reviewed-by: Sean Christopherson <seanjc@...gle.com>
> ---
> Changed since v1:
>    - change 'incorrect' to 'misplaced'
> 
>   arch/x86/include/asm/kvm_host.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 84499aad01a4..318242512407 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -937,9 +937,6 @@ struct kvm_arch {
>   	unsigned int indirect_shadow_pages;
>   	u8 mmu_valid_gen;
>   	struct hlist_head mmu_page_hash[KVM_NUM_MMU_PAGES];
> -	/*
> -	 * Hash table of struct kvm_mmu_page.
> -	 */
>   	struct list_head active_mmu_pages;
>   	struct list_head zapped_obsolete_pages;
>   	struct list_head lpage_disallowed_mmu_pages;
> 

Queued, thanks.

Paolo