linux-kernel - Re: [PATCH v2] media: exynos4-is: add missing call to of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPf9kqOSng5XULJ8qTADfk3VB273dTqY2qoUA3b+MUPJ+g@mail.gmail.com>
Date:   Fri, 26 Feb 2021 11:29:23 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     mchehab@...nel.org, Sylwester Nawrocki <s.nawrocki@...sung.com>,
        linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] media: exynos4-is: add missing call to of_node_put()

On Fri, 26 Feb 2021 at 02:28, Yang Li <yang.lee@...ux.alibaba.com> wrote:
>
> In one of the error paths of the for_each_child_of_node() loop in
> fimc_md_parse_one_endpoint, add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/media/platform/exynos4-is/media-dev.c:489:1-23: WARNING:
> Function "for_each_child_of_node" should have of_node_put() before
> return around line 492.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>

You ignored the comment for this. Anyone can run Coccinelle and it
does not equal "Reported-by" credit. Reported by is for reported bugs,
but I asked three times to you guys to share the reports. This is not
an open way of working.

This should be removed.

Best regards,
Krzysztof