linux-kernel - Re: [PATCH v2 7/7] arm64/Kconfig: Introduce ARCH_MHP_MEMMAP_ON_MEMORY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210226121011.GD3661@localhost.localdomain>
Date:   Fri, 26 Feb 2021 13:10:11 +0100
From:   Oscar Salvador <osalvador@...e.de>
To:     David Hildenbrand <david@...hat.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...nel.org>, VlastimilBabkavbabka@...e.cz,
        pasha.tatashin@...een.com, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, Anshuman Khandual <anshuman.khandual@....com>
Subject: Re: [PATCH v2 7/7] arm64/Kconfig: Introduce
 ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE

On Thu, Feb 25, 2021 at 07:29:23PM +0100, David Hildenbrand wrote:
> On 09.02.21 14:38, Oscar Salvador wrote:
> > Enable arm64 platform to use the MHP_MEMMAP_ON_MEMORY feature.
> > 
> > Signed-off-by: Oscar Salvador <osalvador@...e.de>
> > ---
> >   arch/arm64/Kconfig | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> > index 87fd02a7a62f..d4fb29779cd4 100644
> > --- a/arch/arm64/Kconfig
> > +++ b/arch/arm64/Kconfig
> > @@ -309,6 +309,10 @@ config ARCH_ENABLE_MEMORY_HOTPLUG
> >   config ARCH_ENABLE_MEMORY_HOTREMOVE
> >   	def_bool y
> > +config ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
> > +	def_bool y
> > +	depends on MEMORY_HOTPLUG && SPARSEMEM_VMEMMAP_ENABLE
> > +
> 
> Same comment as for x86-64 variant.

>From arm64/Kconfig:

config ARCH_SPARSEMEM_ENABLE
        def_bool y
        select SPARSEMEM_VMEMMAP_ENABLE

config ARCH_SPARSEMEM_DEFAULT
        def_bool ARCH_SPARSEMEM_ENABLE

config ARCH_SELECT_MEMORY_MODEL
        def_bool ARCH_SPARSEMEM_ENABLE

config ARCH_FLATMEM_ENABLE
        def_bool !NUMA

It seems SPARSEMEM_VMEMMAP_ENABLE is ticked by default unless we are on
a !NUMA system. So make it dependent on SPARSEMEM_VMEMMAP_ENABLE seems
the right thing to do?


-- 
Oscar Salvador
SUSE L3