linux-kernel - Re: [PATCH] fs: Use WARN(1,...)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210226121035.GA2723601@casper.infradead.org>
Date:   Fri, 26 Feb 2021 12:10:35 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Xu Wang <vulab@...as.ac.cn>
Cc:     viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: Use WARN(1,...)

On Fri, Feb 26, 2021 at 09:49:49AM +0000, Xu Wang wrote:
> Use WARN(1,...) rather than printk followed by WARN_ON(1).

This description doesn't match the patch.

> -	WARN(1, KERN_ERR "BUG: Dentry %p{i=%lx,n=%pd} "
> +	WARN(1, "BUG: Dentry %p{i=%lx,n=%pd} "