linux-kernel - Re: Re: [PATCH] RDMA/siw: Fix missing check in siw_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Feb 2021 20:32:22 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Bernard Metzler" <BMT@...ich.ibm.com>
Cc:     kjlu <kjlu@....edu>, "Doug Ledford" <dledford@...hat.com>,
        "Jason Gunthorpe" <jgg@...pe.ca>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: Re:  [PATCH] RDMA/siw: Fix missing check in siw_get_hdr



&quot;Bernard Metzler&quot; &lt;BMT@...ich.ibm.com&gt;写道：
> -----"Dinghao Liu" <dinghao.liu@....edu.cn> wrote: -----
> 
> >To: dinghao.liu@....edu.cn, kjlu@....edu
> >From: "Dinghao Liu" <dinghao.liu@....edu.cn>
> >Date: 02/26/2021 08:56AM
> >Cc: "Bernard Metzler" <bmt@...ich.ibm.com>, "Doug Ledford"
> ><dledford@...hat.com>, "Jason Gunthorpe" <jgg@...pe.ca>,
> >linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
> >Subject: [EXTERNAL] [PATCH] RDMA/siw: Fix missing check in
> >siw_get_hdr
> >
> >We should also check the range of opcode after calling
> >__rdmap_get_opcode() in the else branch to prevent potential
> >overflow.
> 
> Hi Dinghao,
> No this is not needed. We always first read the minimum
> header information (MPA len, DDP flags, RDMAP opcode,
> STag, target offset). Only if we have received that
> into local buffer, we check for the opcode this one time.
> Now the opcode determines the remaining length of the
> variably sized part of the header to be received.
> 
> We do not have to check the opcode again, since we
> already received and checked it.
> 

It's clear to me, thanks!

Regards,
Dinghao