linux-kernel - Re: [PATCH v2 0/3] Fixes & a new supplementary feature to SPRD mailbox driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210226015237.GA2610@lenovo>
Date:   Fri, 26 Feb 2021 09:52:37 +0800
From:   Orson Zhai <orsonzhai@...il.com>
To:     Rob Herring <robh+dt@...nel.org>,
        Baolin Wang <baolin.wang7@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        Jassi Brar <jassisinghbrar@...il.com>
Cc:     Mark Brown <broonie@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Haidong Yao <yaohaidong369@...il.com>
Subject: Re: [PATCH v2 0/3] Fixes & a new supplementary feature to SPRD
 mailbox driver

Hi Baolin,

On Sat, Feb 13, 2021 at 08:21:40PM +0800, Orson Zhai wrote:
> Fix a real problem fot SPRD's mailbox driver in patch 1/3.
> Add supplementary inbox support for newly added sc9863a in patch 3/3 and
> change dt bindings yaml accordingly in patch 2/3.
> 
> Changes Log:
> V2:
> - Change patches order. (Yaml go to the head of dirver)
> - Remove unnecessary initializing refcnt to zero. 
> - Add fix of possible crash caused by NULL of chan->cl. (Actually move from
>   changes to sprd-mailbox.c of patch v1)
> - Remove unnecessary "inline" for do_inbox_isr().
> - Fix yaml errors from Rob's robot checking.
> - Add sc9863a compatible string for real supplementary inbox usage. (sc9860
>   is not supported by supp-inbox)
> - Add more details to supp-inbox in commit messages.

Do you have any comments about this changes to v2?

Thanks,
Orson

> 
> Orson Zhai (3):
>   mailbox: sprd: Introduce refcnt when clients requests/free channels
>   dt-bindings: mailbox: Add interrupt-names to SPRD mailbox
>   mailbox: sprd: Add supplementary inbox support
> 
>  .../bindings/mailbox/sprd-mailbox.yaml        |  18 ++-
>  drivers/mailbox/sprd-mailbox.c                | 135 +++++++++++++-----
>  2 files changed, 117 insertions(+), 36 deletions(-)
> 
> -- 
> 2.17.1
>