linux-kernel - Re: [PATCH RFC v2] mhi: Enable unique QRTR node ID support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Feb 2021 07:48:18 -0700
From:   Jeffrey Hugo <jhugo@...eaurora.org>
To:     Gokul Sriram Palanisamy <gokulsri@...eaurora.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     manivannan.sadhasivam@...aro.org, hemantk@...eaurora.org,
        sricharan@...eaurora.org
Subject: Re: [PATCH RFC v2] mhi: Enable unique QRTR node ID support

On 2/26/2021 3:42 AM, Gokul Sriram Palanisamy wrote:
> On multi-mhi platforms, host WiFi driver and
> QMI test driver needs to differntiate between
> QMI packets received from multiple mhi devices.
> 
> With QCN9000 PCI cards, once SBL gets loaded, we
> utilize ERRDBG2 register to write a unique value
> per mhi device from device-tree that the device
> utilizes to set a unique QRTR node ID and
> instance ID for the QMI service. This helps QRTR
> stack in differenting the packets in a multi-mhi
> environment and can route them accordingly.
> 
> sample:
> root@...nWrt:/# qrtr-lookup
>    Service Version Instance Node  Port
>         15       1        0    8     1 Test service
>         69       1        8    8     2 ATH10k WLAN firmware service
>         15       1        0   24     1 Test service
>         69       1       24   24     2 ATH10k WLAN firmware service
> 
> Here 8 and 24 on column 3 (QMI Instance ID)
> and 4 (QRTR Node ID) are the node IDs that
> is unique per mhi device.
> 
> Changes since v1:
>   - Addressed review comments by Jeffrey Hugo.

No, you didn't.  You fixed the DT comment, but didn't address the rest. 
  This gets a NACK from me.

> 
> Gokul Sriram Palanisamy (1):
>    bus: mhi: core: Add unique qrtr node id support
> 
>   drivers/bus/mhi/core/boot.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 


-- 
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.