linux-kernel - Re: [PATCH] perf vendor events: Remove 'type' field from mapfiles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2b754c2-0994-34a2-c42e-d8323beaf8c5@huawei.com>
Date:   Fri, 26 Feb 2021 16:16:30 +0000
From:   John Garry <john.garry@...wei.com>
To:     Andi Kleen <ak@...ux.intel.com>
CC:     <peterz@...radead.org>, <acme@...nel.org>, <mingo@...hat.com>,
        <mark.rutland@....com>, <jolsa@...hat.com>, <namhyung@...nel.org>,
        <irogers@...gle.com>, <kjain@...ux.ibm.com>,
        <alexander.shishkin@...ux.intel.com>,
        <linux-kernel@...r.kernel.org>, <will@...nel.org>,
        <linuxarm@...wei.com>
Subject: Re: [PATCH] perf vendor events: Remove 'type' field from mapfiles

On 26/02/2021 15:47, Andi Kleen wrote:
> On Fri, Feb 26, 2021 at 09:08:17PM +0800, John Garry wrote:
>> Included for each CPU entry in the per-arch mapfile.csv file is a 'type'
>> field.
> I don't like it because this will make the mapfile incompatible with
> what download.01.org uses. We originally derived it from that.

I assumed that it was this file:
https://download.01.org/perfmon/mapfile.csv

which already has a different format - extra columns - so figured that 
some handcrafting was already going on. Indeed 'type' is not always 
'core' there.

 >
 > It would be ok if it fixed something serious, but as it seems to be
 > more cosmetic I don't think there's a good reason to devivate.
 >

If you're against that, then ok; I suppose jevents handling could still 
be removed, but I'm not enthused.

Thanks,
John