[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bb815b1d-5377-95a1-9610-827a30cb8525@linuxfoundation.org>
Date: Fri, 26 Feb 2021 11:16:40 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Johannes Berg <johannes@...solutions.net>, peterz@...radead.org,
mingo@...hat.com, will@...nel.org, kvalo@...eaurora.org,
davem@...emloft.net, kuba@...nel.org
Cc: ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 2/3] lockdep: add lockdep lock state defines
On 2/26/21 11:03 AM, Johannes Berg wrote:
>
>> @@ -5475,7 +5476,7 @@ noinstr int lock_is_held_type(const struct lockdep_map *lock, int read)
>> /* avoid false negative lockdep_assert_not_held()
>> * and lockdep_assert_held()
>> */
>> - return -1;
>> + return LOCK_STATE_UNKNOWN;
>
> I'd argue that then the other two return places here should also be
> changed.
>
Makes sense.
Since lock_is_held_type() simply returns what __lock_is_held() for the
other cases, __lock_is_held() is the one that needs changes to use these
defines.
thanks,
-- Shuah
Powered by blists - more mailing lists