linux-kernel - Re: [PATCH v1 01/12] gna: add driver module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5A98CC3E-EAA4-46FC-8FCC-36DE862E52A2@linux.intel.com>
Date:   Fri, 26 Feb 2021 13:22:20 -0800
From:   Jianxun Zhang <jianxun.zhang@...ux.intel.com>
To:     Maciej Kwapulinski <maciej.kwapulinski@...ux.intel.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Jonathan Corbet <corbet@....net>,
        Derek Kiernan <derek.kiernan@...inx.com>,
        Dragan Cvetic <dragan.cvetic@...inx.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Documentation List <linux-doc@...r.kernel.org>,
        Tomasz Jankowski <tomasz1.jankowski@...el.com>,
        Savo Novakovic <savox.novakovic@...el.com>
Subject: Re: [PATCH v1 01/12] gna: add driver module



> On Feb 26, 2021, at 10:29 AM, Maciej Kwapulinski <maciej.kwapulinski@...ux.intel.com> wrote:
> 
> 
> Andy Shevchenko <andy.shevchenko@...il.com> writes:
> 
>> On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski
>> <maciej.kwapulinski@...ux.intel.com> wrote:
>>> 
> ....
>>> +#define GNA_DRV_VER    "1.2.0"
>> 
>> Nowadays the version is the Git SHA sum.
>> 
> 
> right, "version" is present in about 7% of all modules
> 
> do You mean version should be skipped over (automatically generated)
> srcversion field? or maybe You suggest any (better) technique?

Just my 0.02. We should identify who will consume this version string for what purposes. Then we can decide if a hardcoded macro or any auto-gen tags should be used. If we don’t find such need, perhaps we just remove it since a snapshot of the code is always tagged  by commit SHA1 in git. (maybe this is what Andy suggested?).

Having such hardcoded version string requires an update policy in return, to make it really useful, IMO.