linux-kernel - Re: [PATCH 2/2] PCI: controller: avoid building empty drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a1DMCUPgJ5CMfJv3MnTLV8cmv0BdeyCuRjsL0oEZwaJ+g@mail.gmail.com>
Date:   Sat, 27 Feb 2021 13:31:21 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Robert Richter <rric@...nel.org>
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Arnd Bergmann <arnd@...db.de>, Rob Herring <robh@...nel.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Bharat Kumar Gogada <bharat.kumar.gogada@...inx.com>,
        Yicong Yang <yangyicong@...ilicon.com>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Daire McNamara <daire.mcnamara@...rochip.com>,
        Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        linux-pci <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] PCI: controller: avoid building empty drivers

On Fri, Feb 26, 2021 at 8:08 PM Robert Richter <rric@...nel.org> wrote:
> On 25.02.21 15:37:10, Arnd Bergmann wrote:
>
> A possible double inclusion isn't really nice here, but it should work
> that way.
>
> Also, the menu entry for the driver is in fact only for the OF case,
> as it is always included for ACPI even if the option is disabled (and
> thus the choice is useless). But this is unrelated to this patch.

Yes, I considered doing this using Kconfig syntax by adding another
symbol for each affected driver and selecting those, but the Makefile
hack seemed easier here.

> Reviewed-by: Robert Richter <rric@...nel.org>

Thanks,

        Arnd