linux-kernel - Re: [GIT PULL] Driver core / debugfs changes for 5.12-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YDpWsXwB6MJPjS7J@kroah.com>
Date:   Sat, 27 Feb 2021 15:26:57 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Saravana Kannan <saravanak@...gle.com>
Subject: Re: [GIT PULL] Driver core / debugfs changes for 5.12-rc1

On Wed, Feb 24, 2021 at 10:20:44AM -0800, Linus Torvalds wrote:
> On Wed, Feb 24, 2021 at 6:27 AM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> >  [..] I've reverted that change at
> > the very end so we don't have to worry about regressions in 5.12.
> 
> Side note: it would have been really nice to see links to the actual
> problem reports in the revert commit.

Odd, this showed up in my gmail spam folder, just saw this now :(

> Yes, there's a "Link:" line there, but that points to the
> less-than-useful patch submission for the revert, not to the actual
> _reasons_ for the revert.
> 
> Now I'm looking at that revert, and I have absolutely no idea why it
> happened. Only a very vague "there are still reported regressions
> happening".
> 
> I've pulled it, but wanted to just point out that when there's some
> fairly fundamental revert like this, it really would be good to link
> to the problems, so that when people try to re-enable it, they have
> the history for why it didn't work the first time.
> 
> Now all that history is basically lost (well, hopefully Saravana and
> you actually remember, but you get my point).

Sorry, the history is on the original commit Link that was reverted, and
in lots of other emails on lkml over the past few weeks.  Next time I'll
include links to those threads as well.

thanks,

greg k-h