linux-kernel - Re: [PATCH 2/5] iio: hid-sensor-als: Support change sensitivity in illuminance too.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210228144525.00000730@Huawei.com>
Date:   Sun, 28 Feb 2021 14:45:25 +0000
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Ronald Tschalär <ronald@...ovation.ch>
CC:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        "Lars-Peter Clausen" <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        <linux-kernel@...r.kernel.org>, <linux-input@...r.kernel.org>,
        <linux-iio@...r.kernel.org>
Subject: Re: [PATCH 2/5] iio: hid-sensor-als: Support change sensitivity in
 illuminance too.

On Sat, 27 Feb 2021 17:26:40 -0800
Ronald Tschalär <ronald@...ovation.ch> wrote:

> Recent MacBook Pro's specify the usage of the change sensitivity field
> as illuminance (with a change sensitivity modifier) rather than as
> light.
> 
> Signed-off-by: Ronald Tschalär <ronald@...ovation.ch>
This looks fine to me though it the hid sensors spec never fails to surprise
me in the different slight variants of the same thing that come up.

Illuminance is at least fairly well defined, but who knows what for the DATA_LIGHT
version takes?

Anyhow, lets give time for Srinivas to sanity check this as he's much more familiar
with that spec than I am.

Jonathan

> ---
>  drivers/iio/light/hid-sensor-als.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c
> index a21c827e4953d..849ee37dcd866 100644
> --- a/drivers/iio/light/hid-sensor-als.c
> +++ b/drivers/iio/light/hid-sensor-als.c
> @@ -252,6 +252,14 @@ static int als_parse_report(struct platform_device *pdev,
>  			HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS |
>  			HID_USAGE_SENSOR_DATA_LIGHT,
>  			&st->common_attributes.sensitivity);
> +
> +		if (st->common_attributes.sensitivity.index < 0)
> +			sensor_hub_input_get_attribute_info(hsdev,
> +				HID_FEATURE_REPORT, usage_id,
> +				HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS |
> +				HID_USAGE_SENSOR_LIGHT_ILLUM,
> +				&st->common_attributes.sensitivity);
> +
>  		dev_dbg(&pdev->dev, "Sensitivity index:report %d:%d\n",
>  			st->common_attributes.sensitivity.index,
>  			st->common_attributes.sensitivity.report_id);