lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Sun, 28 Feb 2021 10:41:39 +0800
From:   kernel test robot <lkp@...el.com>
To:     Alex Shi <alex.shi@...ux.alibaba.com>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>
Subject: mm/compaction.c:463:20: warning: unused function 'isolation_suitable'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5695e51619745d4fe3ec2506a2f0cd982c5e27a4
commit: 9df41314390b81a541ca6e84c8340bad0959e4b5 mm/compaction: do page isolation first in compaction
date:   2 months ago
config: mips-randconfig-r004-20210228 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 83bc7815c4235786111aa2abf7193292e4a602f5)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9df41314390b81a541ca6e84c8340bad0959e4b5
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 9df41314390b81a541ca6e84c8340bad0959e4b5
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   mm/compaction.c:56:27: warning: unused variable 'HPAGE_FRAG_CHECK_INTERVAL_MSEC'
   static const unsigned int HPAGE_FRAG_CHECK_INTERVAL_MSEC = 500;
   ^
>> mm/compaction.c:463:20: warning: unused function 'isolation_suitable'
   static inline bool isolation_suitable(struct compact_control
   ^
>> mm/compaction.c:469:20: warning: unused function 'pageblock_skip_persistent'
   static inline bool pageblock_skip_persistent(struct page
   ^
>> mm/compaction.c:474:20: warning: unused function 'update_pageblock_skip'
   static inline void update_pageblock_skip(struct compact_control
   ^
   fatal error: error in backend: Nested variants found in inline asm string: ' .set push
   .set noat
   .set push
   .set arch=r4000
   .if ( 0x00 ) != -1)) 0x00 ) != -1)) : ($( static struct ftrace_branch_data __attribute__((__aligned__(4))) __attribute__((__section__("_ftrace_branch"))) __if_trace = $( .func = __func__, .file = "arch/mips/include/asm/cmpxchg.h", .line = 163, $); 0x00 ) != -1)) : $))) ) && ( 0 ); .set push; .set mips64r2; .rept 1; sync 0x00; .endr; .set pop; .else; ; .endif
   1: ll $0, $2 # __cmpxchg_asm
   bne $0, ${3:z}, 2f
   .set pop
   move $$1, ${4:z}
   .set arch=r4000
   sc $$1, $1
   beqz $$1, 1b
   .set pop
   2: .if ( 0x00 ) != -1)) 0x00 ) != -1)) : ($( static struct ftrace_branch_data __attribute__((__aligned__(4))) __attribute__((__section__("_ftrace_branch"))) __if_trace = $( .func = __func__, .file = "arch/mips/include/asm/cmpxchg.h", .line = 163, $); 0x00 ) != -1)) : $))) ) && ( 0 ); .set push; .set mips64r2; .rept 1; sync 0x00; .endr; .set pop; .else; ; .endif
   '
   clang-13: error: clang frontend command failed with exit code 70 (use -v to see invocation)
   clang version 13.0.0 (git://gitmirror/llvm_project e0b1df924ae06d6d88582334087d2eacc6702e8f)
   Target: mipsel-unknown-linux-gnu
   Thread model: posix
   InstalledDir: /opt/cross/clang-e0b1df924a/bin
   clang-13: note: diagnostic msg:
   Makefile arch block certs crypto drivers fs include init ipc kernel lib mm net scripts security sound source usr virt


vim +/isolation_suitable +463 mm/compaction.c

e380bebe477154 Mel Gorman      2019-03-05  440  
bb13ffeb9f6bfe Mel Gorman      2012-10-08  441  /*
bb13ffeb9f6bfe Mel Gorman      2012-10-08  442   * If no pages were isolated then mark this pageblock to be skipped in the
62997027ca5b3d Mel Gorman      2012-10-08  443   * future. The information is later cleared by __reset_isolation_suitable().
bb13ffeb9f6bfe Mel Gorman      2012-10-08  444   */
c89511ab2f8fe2 Mel Gorman      2012-10-08  445  static void update_pageblock_skip(struct compact_control *cc,
d097a6f6352254 Mel Gorman      2019-03-05  446  			struct page *page, unsigned long pfn)
bb13ffeb9f6bfe Mel Gorman      2012-10-08  447  {
c89511ab2f8fe2 Mel Gorman      2012-10-08  448  	struct zone *zone = cc->zone;
6815bf3f233e0b Joonsoo Kim     2013-12-18  449  
2583d6713267a4 Vlastimil Babka 2017-11-17  450  	if (cc->no_set_skip_hint)
6815bf3f233e0b Joonsoo Kim     2013-12-18  451  		return;
6815bf3f233e0b Joonsoo Kim     2013-12-18  452  
bb13ffeb9f6bfe Mel Gorman      2012-10-08  453  	if (!page)
bb13ffeb9f6bfe Mel Gorman      2012-10-08  454  		return;
bb13ffeb9f6bfe Mel Gorman      2012-10-08  455  
bb13ffeb9f6bfe Mel Gorman      2012-10-08  456  	set_pageblock_skip(page);
c89511ab2f8fe2 Mel Gorman      2012-10-08  457  
35979ef3393110 David Rientjes  2014-06-04  458  	/* Update where async and sync compaction should restart */
35979ef3393110 David Rientjes  2014-06-04  459  	if (pfn < zone->compact_cached_free_pfn)
c89511ab2f8fe2 Mel Gorman      2012-10-08  460  		zone->compact_cached_free_pfn = pfn;
c89511ab2f8fe2 Mel Gorman      2012-10-08  461  }
bb13ffeb9f6bfe Mel Gorman      2012-10-08  462  #else
bb13ffeb9f6bfe Mel Gorman      2012-10-08 @463  static inline bool isolation_suitable(struct compact_control *cc,
bb13ffeb9f6bfe Mel Gorman      2012-10-08  464  					struct page *page)
bb13ffeb9f6bfe Mel Gorman      2012-10-08  465  {
bb13ffeb9f6bfe Mel Gorman      2012-10-08  466  	return true;
bb13ffeb9f6bfe Mel Gorman      2012-10-08  467  }
bb13ffeb9f6bfe Mel Gorman      2012-10-08  468  
b527cfe5bc2320 Vlastimil Babka 2017-11-17 @469  static inline bool pageblock_skip_persistent(struct page *page)
21dc7e023611fb David Rientjes  2017-11-17  470  {
21dc7e023611fb David Rientjes  2017-11-17  471  	return false;
21dc7e023611fb David Rientjes  2017-11-17  472  }
21dc7e023611fb David Rientjes  2017-11-17  473  
21dc7e023611fb David Rientjes  2017-11-17 @474  static inline void update_pageblock_skip(struct compact_control *cc,
d097a6f6352254 Mel Gorman      2019-03-05  475  			struct page *page, unsigned long pfn)
e380bebe477154 Mel Gorman      2019-03-05  476  {
e380bebe477154 Mel Gorman      2019-03-05  477  }
e380bebe477154 Mel Gorman      2019-03-05  478  

:::::: The code at line 463 was first introduced by commit
:::::: bb13ffeb9f6bfeb301443994dfbf29f91117dfb3 mm: compaction: cache if a pageblock was scanned and no pages were isolated

:::::: TO: Mel Gorman <mgorman@...e.de>
:::::: CC: Linus Torvalds <torvalds@...ux-foundation.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (39485 bytes)

Powered by blists - more mailing lists