linux-kernel - Re: [PATCH 05/11] pragma once: convert drivers/scsi/qla2xxx/qla

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e617be2f-04cf-2ffb-50b8-9b7be31fb77a@acm.org>
Date:   Sun, 28 Feb 2021 14:07:17 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Alexey Dobriyan <adobriyan@...il.com>,
        torvalds@...ux-foundation.org
Cc:     linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        njavali@...vell.com, GR-QLogic-Storage-Upstream@...vell.com,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH 05/11] pragma once: convert
 drivers/scsi/qla2xxx/qla_target.h

On 2/28/21 9:01 AM, Alexey Dobriyan wrote:
> This file has broken include guard which is not obvious just by looking
> at the code. Convert it manually. I think I got #endif right.

Why do you think that the include guard is broken? Please mention this
in the patch description.

> -
> -#ifndef __QLA_TARGET_H
> -#define __QLA_TARGET_H
> -
> +#pragma once
>  #include "qla_def.h"
>  #include "qla_dsd.h"

Please insert a blank line between #pragma once and the #include directives.

Thanks,

Bart.