linux-kernel - Re: [PATCH v6 02/24] iio: kfifo: add devm_iio_kfifo_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e6f90be-5dbf-1356-d1ac-22a4273c87ee@metafoo.de>
Date:   Sun, 28 Feb 2021 09:06:07 +0100
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Cc:     Michael.Hennerich@...log.com, jic23@...nel.org, nuno.sa@...log.com,
        dragos.bogdan@...log.com
Subject: Re: [PATCH v6 02/24] iio: kfifo: add devm_iio_kfifo_buffer_setup()
 helper

On 2/15/21 11:40 AM, Alexandru Ardelean wrote:
> +int devm_iio_kfifo_buffer_setup(struct device *dev,
> +				struct iio_dev *indio_dev,
> +				int mode_flags,
> +				const struct iio_buffer_setup_ops *setup_ops)
> +{
> +	struct iio_buffer *buffer;
> +
> +	if (mode_flags)
> +		mode_flags &= kfifo_access_funcs.modes;

The if seems unnecessary. If it is 0 and we AND it with something it is 
still 0.