linux-kernel - Re: [PATCH 1/2] powercap/drivers/dtpm: Fix root node initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0igJztj3fRoGh9AjAPfe01wsBT27X8b19HAyr0t2kRgtg@mail.gmail.com>
Date:   Mon, 1 Mar 2021 17:45:29 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 1/2] powercap/drivers/dtpm: Fix root node initialization

On Wed, Feb 24, 2021 at 7:30 PM Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
>
> The root node is not set to NULL when the dtpm root node is
> removed. Consequently, it is not possible to create a new root as it
> is already set.
>
> Set the root node to NULL when the last node is removed.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>  drivers/powercap/dtpm.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c
> index 5a51cd34a7e8..c2185ec5f887 100644
> --- a/drivers/powercap/dtpm.c
> +++ b/drivers/powercap/dtpm.c
> @@ -207,6 +207,9 @@ int dtpm_release_zone(struct powercap_zone *pcz)
>         if (dtpm->ops)
>                 dtpm->ops->release(dtpm);
>
> +       if (root == dtpm)
> +               root = NULL;
> +
>         kfree(dtpm);
>
>         return 0;
> --

Applied along with the [2/2[ as 5.12-rc material, thanks!