linux-kernel - Re: [PATCH v2] misc: fastrpc: restrict user apps from sending kernel RPC messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJprTwqFWfPMjLrA2T0rJ=D3btLFHwY33VVJka1Og-9UeAQ@mail.gmail.com>
Date:   Mon, 1 Mar 2021 20:45:34 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        open list <linux-kernel@...r.kernel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Jonathan Marek <jonathan@...ek.ca>, stable@...r.kernel.org,
        Nicolas Dechesne <nicolas.dechesne@...aro.org>
Subject: Re: [PATCH v2] misc: fastrpc: restrict user apps from sending kernel
 RPC messages

On Mon, 1 Mar 2021 at 18:48, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Mon, Mar 01, 2021 at 06:34:10PM +0300, Dmitry Baryshkov wrote:
> > On Sat, 13 Feb 2021 at 11:25, Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org> wrote:
> > >
> > > On Fri, Feb 12, 2021 at 10:26:58PM +0300, Dmitry Baryshkov wrote:
> > > > Verify that user applications are not using the kernel RPC message
> > > > handle to restrict them from directly attaching to guest OS on the
> > > > remote subsystem. This is a port of CVE-2019-2308 fix.
> > >
> > > A port of the fix of what to what?
> >
> > I'm sorry for the confusion. It is a port of the original
> > Qualcomm/CodeAurora fix to the upstream driver.
> >
> > See https://source.codeaurora.org/quic/la/kernel/msm-4.9/commit/?id=cc2e11eeb988964af72309f71b0fb21c11ed6ca9,
>
> So this is a fix from 2019 that you never submitted upstream causing all
> of these kernels to be vulnerable?

It seems there is some kind of confusion here.
Srinivas and Thierry have developed the fastrpc driver. It is not the
same as the driver developed by Qualcomm. However in this case it
suffers from the same problem as the original adsprpc driver..
We have submitted the fix as soon as we've noticed the issue.

> Shouldn't the porting process go the other way, upstream first and then
> backport?  That ensures we don't end up with 2 years old bugs like this
> :(
>
> Ugh.
>
> What's going to change in the development process of this code to
> prevent this from happening again?

-- 
With best wishes
Dmitry