linux-kernel - RE: [PATCH 4/4] staging:rtl8712: replace cap_* definitions with native kernel WLAN_CAPABILITY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 1 Mar 2021 08:11:29 +0000
From:   "Chen, Mike Ximing" <mike.ximing.chen@...el.com>
To:     Ivan Safonov <insafonov@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Michael Straube <straube.linux@...il.com>,
        Pascal Terjan <pterjan@...gle.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 4/4] staging:rtl8712: replace cap_* definitions with
 native kernel WLAN_CAPABILITY_*


> -----Original Message-----
> From: Ivan Safonov <insafonov@...il.com>
> Sent: Saturday, February 27, 2021 5:23 PM
> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Florian Schilhabel <florian.c.schilhabel@...glemail.com>; Larry Finger
> <Larry.Finger@...inger.net>; Michael Straube <straube.linux@...il.com>; Pascal
> Terjan <pterjan@...gle.com>; devel@...verdev.osuosl.org; linux-
> kernel@...r.kernel.org; Ivan Safonov <insafonov@...il.com>
> Subject: [PATCH 4/4] staging:rtl8712: replace cap_* definitions with native kernel
> WLAN_CAPABILITY_*
> 
> cap_* definitions duplicate WLAN_CAPABILITY_*. Remove cap_* definitions,
> improve code consistency.
> 
> Signed-off-by: Ivan Safonov <insafonov@...il.com>
> ---
>  drivers/staging/rtl8712/ieee80211.c | 6 +++---
>  drivers/staging/rtl8712/wifi.h      | 7 -------
>  2 files changed, 3 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/ieee80211.c
> b/drivers/staging/rtl8712/ieee80211.c
> index b4a099169c7c..13fc3c1ec0db 100644
> --- a/drivers/staging/rtl8712/ieee80211.c
> +++ b/drivers/staging/rtl8712/ieee80211.c
> @@ -173,11 +173,11 @@ int r8712_generate_ie(struct registry_priv *registrypriv)
>  	ie += 2;
>  	/*capability info*/
>  	*(u16 *)ie = 0;
> -	*(__le16 *)ie |= cpu_to_le16(cap_IBSS);
> +	*(__le16 *)ie |= cpu_to_le16(WLAN_CAPABILITY_IBSS);
>  	if (registrypriv->preamble == PREAMBLE_SHORT)
> -		*(__le16 *)ie |= cpu_to_le16(cap_ShortPremble);
> +		*(__le16 *)ie |=
> cpu_to_le16(WLAN_CAPABILITY_SHORT_PREAMBLE);
>  	if (dev_network->Privacy)
> -		*(__le16 *)ie |= cpu_to_le16(cap_Privacy);
> +		*(__le16 *)ie |= cpu_to_le16(WLAN_CAPABILITY_PRIVACY);
>  	sz += 2;
>  	ie += 2;
>  	/*SSID*/
> diff --git a/drivers/staging/rtl8712/wifi.h b/drivers/staging/rtl8712/wifi.h
> index b7889ac3dce9..f941efb1f4e2 100644
> --- a/drivers/staging/rtl8712/wifi.h
> +++ b/drivers/staging/rtl8712/wifi.h
> @@ -278,13 +278,6 @@ static inline unsigned char *get_hdr_bssid(unsigned char
> *pframe)
>  #define AUTH_ODD_TO				0
>  #define AUTH_EVEN_TO			1
> 
> -#define cap_ESS BIT(0)
> -#define cap_IBSS BIT(1)
> -#define cap_CFPollable BIT(2)
> -#define cap_CFRequest BIT(3)
> -#define cap_Privacy BIT(4)
> -#define cap_ShortPremble BIT(5)
> -
>  /*-----------------------------------------------------------------------------
>   *			Below is the definition for 802.11i / 802.1x
>   *------------------------------------------------------------------------------
> --
> 2.26.2

Reviewed-by: Mike Ximing Chen <mike.ximing.chen@...el.com>