linux-kernel - Re: futex breakage in 4.9 stable branch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210301083549.GF641347@dell>
Date:   Mon, 1 Mar 2021 08:35:49 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Ben Hutchings <ben@...adent.org.uk>, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
        stable@...r.kernel.org,
        "Luis Claudio R. Goncalves" <lgoncalv@...hat.com>, lwn@....net,
        jslaby@...e.cz
Subject: Re: futex breakage in 4.9 stable branch

On Mon, 01 Mar 2021, Greg Kroah-Hartman wrote:

> On Mon, Mar 01, 2021 at 01:13:08AM +0100, Ben Hutchings wrote:
> > On Tue, 2021-02-23 at 15:00 +0100, Greg Kroah-Hartman wrote:
> > > I'm announcing the release of the 4.9.258 kernel.
> > > 
> > > All users of the 4.9 kernel series must upgrade.
> > > 
> > > The updated 4.9.y git tree can be found at:
> > >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.9.y
> > > and can be browsed at the normal kernel.org git web browser:
> > >         
> > 
> > The backported futex fixes are still incomplete/broken in this version.
> > If I enable lockdep and run the futex self-tests (from 5.10):
> > 
> > - on 4.9.246, they pass with no lockdep output
> > - on 4.9.257 and 4.9.258, they pass but futex_requeue_pi trigers a
> >   lockdep splat
> > 
> > I have a local branch that essentially updates futex and rtmutex in
> > 4.9-stable to match 4.14-stable.  With this, the tests pass and lockdep
> > is happy.
> > 
> > Unfortunately, that branch has about another 60 commits.  Further, the
> > more we change futex in 4.9, the more difficult it is going to be to
> > update the 4.9-rt branch.  But I don't see any better option available
> > at the moment.
> > 
> > Thoughts?
> 
> There were some posted futex fixes for 4.9 (and 4.4) on the stable list
> that I have not gotten to yet.
> 
> Hopefully after these are merged (this week), these issues will be
> resolved.
> 
> If not, then yes, they need to be fixed and any help you can provide
> would be appreciated.
> 
> As for "difficulty", yes, it's rough, but the changes backported were
> required, for obvious reasons :(

Apologies for the fuss.

The back-port become more complex the further back it was taken..

Had I known about the self-tests, I would have ensured those were
passing too, as well as the the build/boot/auto-builder tests
actually carried out.

Let me know if there's anything further I can do to help.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog