linux-kernel - Re: [f2fs-dev] [PATCH 2/3] f2fs: fix last_lblock check in check_swap_activate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa06822f-89eb-19ca-674b-929273bd3717@huawei.com>
Date:   Mon, 1 Mar 2021 10:01:12 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Huang Jianan <huangjianan@...o.com>,
        <linux-f2fs-devel@...ts.sourceforge.net>
CC:     <linux-kernel@...r.kernel.org>, <zhangshiming@...o.com>
Subject: Re: [f2fs-dev] [PATCH 2/3] f2fs: fix last_lblock check in
 check_swap_activate_fast

On 2021/2/27 20:02, Huang Jianan via Linux-f2fs-devel wrote:
> Because page_no < sis->max guarantees that the while loop break out
> normally, the wrong check contidion here doesn't cause a problem.
> 
> Signed-off-by: Huang Jianan <huangjianan@...o.com>
> Signed-off-by: Guo Weichao <guoweichao@...o.com>
> ---
>   fs/f2fs/data.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index a1498a1a345c..4dbc1cafc55d 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -3804,7 +3804,7 @@ static int check_swap_activate_fast(struct swap_info_struct *sis,
>   	last_lblock = bytes_to_blks(inode, i_size_read(inode));
>   	len = i_size_read(inode);
>   
> -	while (cur_lblock <= last_lblock && cur_lblock < sis->max) {
> +	while (cur_lblock + 1 <= last_lblock && cur_lblock < sis->max) {

while (cur_lblock < last_lblock && cur_lblock < sis->max) {

It's nitpick, if necessary, I guess Jaegeuk could help to change this
while merging.

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,

>   		struct f2fs_map_blocks map;
>   		pgoff_t next_pgofs;
>   
>