[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210301110427.GT7604@suse.cz>
Date: Mon, 1 Mar 2021 12:04:27 +0100
From: David Sterba <dsterba@...e.cz>
To: Christoph Hellwig <hch@....de>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>,
Andrew Morton <akpm@...ux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux Next Mailing List <linux-next@...r.kernel.org>,
Martin Raiber <martin@...ackup.org>,
"Matthew Wilcox (Oracle)" <willy@...radead.org>
Subject: Re: linux-next: manual merge of the akpm-current tree with the btrfs
tree
On Fri, Feb 26, 2021 at 06:16:26AM +0100, Christoph Hellwig wrote:
> On Fri, Feb 26, 2021 at 10:32:50AM +1100, Stephen Rothwell wrote:
> > > > - return filemap_read(iocb, to, ret);
> > > > + if (iocb->ki_flags & IOCB_NOWAIT)
> > > > + iocb->ki_flags |= IOCB_NOIO;
> > > > +
> > > > - ret = generic_file_buffered_read(iocb, to, ret);
> > > > ++ ret = filemap_read(iocb, to, ret);
> > > > +
> > > > + if (iocb->ki_flags & IOCB_NOWAIT) {
> > > > + iocb->ki_flags &= ~IOCB_NOIO;
> > > > + if (ret == 0)
> > > > + ret = -EAGAIN;
> > > > + }
> > > > +
> > > > + return ret;
> > > > }
>
> I think the above code looks completely bogus. Instead whatever code
> in btrfs hecks for IOCB_NOIO to avoid blocking readahead should also
> check IOCB_NOWAIT.
Thanks for the comment, I've removed the patch from for-next and
notified the authors.
Powered by blists - more mailing lists