[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210301113259.wpqmjutdhw6thzku@wittgenstein>
Date: Mon, 1 Mar 2021 12:32:59 +0100
From: Christian Brauner <christian.brauner@...ntu.com>
To: Wang Qing <wangqing@...o.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Thomas Gleixner <tglx@...utronix.de>,
Thomas Cedeno <thomascedeno@...gle.com>,
Nicolas Viennot <Nicolas.Viennot@...sigma.com>,
Michel Lespinasse <walken@...gle.com>,
Rasmus Villemoes <linux@...musvillemoes.dk>,
Al Viro <viro@...iv.linux.org.uk>,
Gabriel Krisman Bertazi <krisman@...labora.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: Return -EFAULT if copy_to_user() fails
On Mon, Mar 01, 2021 at 07:28:11PM +0800, Wang Qing wrote:
> The copy_to_user() function returns the number of bytes remaining to be
> copied, but we want to return -EFAULT if the copy doesn't complete.
>
> Signed-off-by: Wang Qing <wangqing@...o.com>
> ---
Hey Wang,
Thanks for the patch. It looks like override_release() is called in
three places and all three places return -EFAULT correctly. They simply
treat any as EFAULT. So not sure this change buys us anything.
Christian
Powered by blists - more mailing lists