linux-kernel - Re: [PATCH v2 1/3] clk: generalize devm_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Mar 2021 20:41:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
Cc:     kbuild-all@...ts.01.org, linux-pwm@...r.kernel.org,
        linux-clk@...r.kernel.org, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH v2 1/3] clk: generalize devm_clk_get() a bit

Hi "Uwe,

I love your patch! Perhaps something to improve:

[auto build test WARNING on fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8]

url:    https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/clk-provide-new-devm-helpers-for-prepared-and-enabled-clocks/20210301-191522
base:   fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8
config: nds32-defconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/bf2779180284ed39480360900c07ce553f75e06a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Uwe-Kleine-K-nig/clk-provide-new-devm-helpers-for-prepared-and-enabled-clocks/20210301-191522
        git checkout bf2779180284ed39480360900c07ce553f75e06a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/clk/clk-devres.c:22:13: warning: no previous prototype for '__devm_clk_get' [-Wmissing-prototypes]
      22 | struct clk *__devm_clk_get(struct device *dev, const char *id,
         |             ^~~~~~~~~~~~~~


vim +/__devm_clk_get +22 drivers/clk/clk-devres.c

    21	
  > 22	struct clk *__devm_clk_get(struct device *dev, const char *id,
    23				   struct clk *(*get)(struct device *dev, const char *id),
    24				   int (*init)(struct clk *clk),
    25				   void (*exit)(struct clk *clk))
    26	{
    27		struct devm_clk_state *state;
    28		struct clk *clk;
    29		int ret;
    30	
    31		state = devres_alloc(devm_clk_release, sizeof(*state), GFP_KERNEL);
    32		if (!state)
    33			return ERR_PTR(-ENOMEM);
    34	
    35		clk = get(dev, id);
    36		if (IS_ERR(clk)) {
    37			ret = PTR_ERR(clk);
    38			goto err_clk_get;
    39		}
    40	
    41		if (init) {
    42			ret = init(clk);
    43			if (ret)
    44				goto err_clk_init;
    45		}
    46	
    47		state->clk = clk;
    48		state->exit = exit;
    49	
    50		devres_add(dev, state);
    51	
    52		return clk;
    53	
    54	err_clk_init:
    55	
    56		clk_put(clk);
    57	err_clk_get:
    58	
    59		devres_free(state);
    60		return ERR_PTR(ret);
    61	}
    62	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (10797 bytes)