linux-kernel - Re: [External] Re: [PATCH v17 1/9] mm: memory_hotplug: factor out bootmem core functions to bootmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 1 Mar 2021 11:01:23 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     "Bodeddula, Balasubramaniam" <bodeddub@...zon.com>
Cc:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "almasrymina@...gle.com" <almasrymina@...gle.com>,
        "anshuman.khandual@....com" <anshuman.khandual@....com>,
        "bp@...en8.de" <bp@...en8.de>, "corbet@....net" <corbet@....net>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "david@...hat.com" <david@...hat.com>,
        "duanxiongchun@...edance.com" <duanxiongchun@...edance.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "joao.m.martins@...cle.com" <joao.m.martins@...cle.com>,
        "jroedel@...e.de" <jroedel@...e.de>,
        "linmiaohe@...wei.com" <linmiaohe@...wei.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "luto@...nel.org" <luto@...nel.org>,
        "mchehab+huawei@...nel.org" <mchehab+huawei@...nel.org>,
        "mhocko@...e.com" <mhocko@...e.com>,
        "mike.kravetz@...cle.com" <mike.kravetz@...cle.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "naoya.horiguchi@....com" <naoya.horiguchi@....com>,
        "oneukum@...e.com" <oneukum@...e.com>,
        "osalvador@...e.de" <osalvador@...e.de>,
        "paulmck@...nel.org" <paulmck@...nel.org>,
        "pawan.kumar.gupta@...ux.intel.com" 
        <pawan.kumar.gupta@...ux.intel.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "rientjes@...gle.com" <rientjes@...gle.com>,
        "song.bao.hua@...ilicon.com" <song.bao.hua@...ilicon.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "willy@...radead.org" <willy@...radead.org>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [External] Re: [PATCH v17 1/9] mm: memory_hotplug: factor out
 bootmem core functions to bootmem_info.c

On Sat, Feb 27, 2021 at 2:06 AM Bodeddula, Balasubramaniam
<bodeddub@...zon.com> wrote:
>
> Tested-by: bodeddub@...zon.com

Very thanks for your test.

>
>
>
> We are interested in this patch and have tested an earlier version of this patch on 5.11-rc4 kernel version. I did a functional validation of the changes and saw that the total memory listed by free command increasing and more memory was made available when memory was allocated in hugepages. 1G hugepages gave higher improvements compared to 2M, as expected. Is there a formal way to publish the results? I can do the same as required (I am new to Linux Kernel patching process).

I don’t know if there is a formal way. But maybe you can share
the test result directly through this thread. If someone knows
this, please let me know. Thanks.

>
>
>
> I have a few follow-up questions on this patch:
>
> 1. What is the overall status of this patch? What is the ballpark timeline we are looking for this patch to be accepted.

There is only one patch of this patchset that has no reviewed-by tag.
I think it might be 5.13 in the best case But I don't have the right to
decide.

>
> 2. Why is this patch not working when memory is allocated as hugepages by THP (transparent hugepages). THP uses AnonHugePages, doesn’t this patch generalize for all ‘type’ of hugepages?

Now it only supports HugeTLB pages. THP is a little different
and complex compared to HugeTLB. I need to investigate THP
in depth to determine the possible problems.

>
>
>
> Please let me know if there are any additional tasks that I can help. Happy to help.
>
>
>
> Thanks.