[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdYpO6xXkswSO_wRLJNeeO6LZtT_W+KN-ECRyCc+ybU7VA@mail.gmail.com>
Date: Mon, 1 Mar 2021 14:58:59 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: DENG Qingfang <dqfext@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>,
Vivien Didelot <vivien.didelot@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
netdev <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: dsa: tag_rtl4_a: fix egress tags
On Sun, Feb 28, 2021 at 6:08 PM DENG Qingfang <dqfext@...il.com> wrote:
> Commit 86dd9868b878 has several issues, but was accepted too soon
> before anyone could take a look.
>
> - Double free. dsa_slave_xmit() will free the skb if the xmit function
> returns NULL, but the skb is already freed by eth_skb_pad(). Use
> __skb_put_padto() to avoid that.
> - Unnecessary allocation. It has been done by DSA core since commit
> a3b0b6479700.
> - A u16 pointer points to skb data. It should be __be16 for network
> byte order.
> - Typo in comments. "numer" -> "number".
>
> Fixes: 86dd9868b878 ("net: dsa: tag_rtl4_a: Support also egress tags")
> Signed-off-by: DENG Qingfang <dqfext@...il.com>
Ooops I send patches before properly going through the mailbox.
Oh well things like that happen.
David: ignore my patches to the same tagger and apply this instead!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
Yours,
Linus Walleij
Powered by blists - more mailing lists