linux-kernel - Re: [PATCH v6 1/2] dt-bindings: hwlock: add sun6i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210301150635.480934a8@monster.powergraphx.local>
Date:   Mon, 1 Mar 2021 15:06:35 +0100
From:   Wilken Gottwalt <wilken.gottwalt@...teo.net>
To:     Maxime Ripard <mripard@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Ohad Ben-Cohen <ohad@...ery.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Baolin Wang <baolin.wang7@...il.com>,
        Rob Herring <robh+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...l.net>
Subject: Re: [PATCH v6 1/2] dt-bindings: hwlock: add sun6i_hwspinlock

On Mon, 1 Mar 2021 14:12:44 +0100
Maxime Ripard <mripard@...nel.org> wrote:

> On Sat, Feb 27, 2021 at 02:03:28PM +0100, Wilken Gottwalt wrote:
> > Adds documentation on how to use the sun6i_hwspinlock driver for sun6i
> > compatible series SoCs.
> >
> > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@...teo.net>
> > ---
> > Changes in v6:
> >   - fixed formating and name issues in dt documentation
> >
> > Changes in v5:
> >   - changed binding to earliest known supported SoC sun6i-a31
> >   - dropped unnecessary entries
> >
> > Changes in v4:
> >   - changed binding to sun8i-a33-hwpinlock
> >   - added changes suggested by Maxime Ripard
> >
> > Changes in v3:
> >   - changed symbols from sunxi to sun8i
> >
> > Changes in v2:
> >   - fixed memory ranges
> > ---
> >  .../hwlock/allwinner,sun6i-hwspinlock.yaml    | 45 +++++++++++++++++++
> 
> The name of the file doesn't match the compatible, once fixed:
> Acked-by: Maxime Ripard <mripard@...nel.org>

This is something that still confuses me. What if you have more than one
compatible string? This won't be solvable. See the qcom binding for example,
there are two strings and none matches. In the omap bindings are also two
strings and only one matches. In all cases, including mine, the bindings
check script is fine with that.

So, you basically want it to be called "allwinner,sun6i-a31-hwspinlock.yaml"?

Sorry if I come up with this, but I don't want to just do it, I want to
understand it.

> Maxime