linux-kernel - Re: [PATCH 4.9.y 1/1] futex: Fix OWNER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YDz2/ratMYUR5SZV@kroah.com>
Date:   Mon, 1 Mar 2021 15:15:26 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Zheng Yejian <zhengyejian1@...wei.com>
Cc:     lee.jones@...aro.org, stable@...r.kernel.org,
        linux-kernel@...r.kernel.org, tglx@...utronix.de,
        cj.chengjian@...wei.com, judy.chenhui@...wei.com,
        zhangjinhao2@...wei.com
Subject: Re: [PATCH 4.9.y 1/1] futex: Fix OWNER_DEAD fixup

On Tue, Feb 23, 2021 at 10:41:51PM +0800, Zheng Yejian wrote:
> From: Peter Zijlstra <peterz@...radead.org>
> 
> commit a97cb0e7b3f4c6297fd857055ae8e895f402f501 upstream.
> 
> Both Geert and DaveJ reported that the recent futex commit:
> 
>   c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex")
> 
> introduced a problem with setting OWNER_DEAD. We set the bit on an
> uninitialized variable and then entirely optimize it away as a
> dead-store.
> 
> Move the setting of the bit to where it is more useful.
> 
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Reported-by: Dave Jones <davej@...emonkey.org.uk>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Paul E. McKenney <paulmck@...ibm.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Fixes: c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex")
> Link: http://lkml.kernel.org/r/20180122103947.GD2228@hirez.programming.kicks-ass.net
> Signed-off-by: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Zheng Yejian <zhengyejian1@...wei.com>
> ---
>  kernel/futex.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Now queued up, thanks.

greg k-h