linux-kernel - Re: [PATCH 3/5] HID: core: Export some report item parsing functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vfd6wZwg9HWJoEwvzAAZR=8K2zDWbz4FZfbbrJBvZS4yQ@mail.gmail.com>
Date:   Mon, 1 Mar 2021 16:18:32 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Ronald Tschalär <ronald@...ovation.ch>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-input <linux-input@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>
Subject: Re: [PATCH 3/5] HID: core: Export some report item parsing functions.

On Sun, Feb 28, 2021 at 3:30 AM Ronald Tschalär <ronald@...ovation.ch> wrote:
>
> These are useful to drivers that need to scan or parse reports
> themselves.

...

> -       while ((start = fetch_item(start, end, &item)) != NULL)
> +       while ((start = hid_fetch_item(start, end, &item)) != NULL)
>                 dispatch_type[item.type](parser, &item);

> -       while ((next = fetch_item(start, end, &item)) != NULL) {
> +       while ((next = hid_fetch_item(start, end, &item)) != NULL) {
>                 start = next;

I don't see the full picture, but perhaps you may also introduce
for_each_hid_item() or so.

-- 
With Best Regards,
Andy Shevchenko