linux-kernel - [PATCH] PM / devfreq: fix odd_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2103011553490.2899@hadrien>
Date:   Mon, 1 Mar 2021 15:55:23 +0100 (CET)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Saravana Kannan <skannan@...eaurora.org>
cc:     Chanwoo Choi <cw00.choi@...sung.com>,
        Sibi Sankar <sibis@...eaurora.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        kbuild-all@...ts.01.org
Subject: [PATCH] PM / devfreq: fix odd_ptr_err.cocci warnings (fwd)

Hello,

There seems to be an inconsistency, but the patch proposed by Coccinelle
does not look correct.  There should be a test on opp_table.

julia

---------- Forwarded message ----------
Date: Mon, 1 Mar 2021 16:35:52 +0800
From: kernel test robot <lkp@...el.com>
To: kbuild@...ts.01.org
Cc: lkp@...el.com, Julia Lawall <julia.lawall@...6.fr>
Subject: [PATCH] PM / devfreq: fix odd_ptr_err.cocci warnings

CC: kbuild-all@...ts.01.org
TO: Saravana Kannan <skannan@...eaurora.org>
CC: Chanwoo Choi <cw00.choi@...sung.com>
CC: Sibi Sankar <sibis@...eaurora.org>
CC: MyungJoo Ham <myungjoo.ham@...sung.com>
CC: Kyungmin Park <kyungmin.park@...sung.com>
CC: linux-pm@...r.kernel.org
CC: linux-kernel@...r.kernel.org

From: kernel test robot <lkp@...el.com>

drivers/devfreq/governor_passive.c:318:7-13: inconsistent IS_ERR and PTR_ERR on line 319.

 PTR_ERR should access the value just tested by IS_ERR

Semantic patch information:
 There can be false positives in the patch case, where it is the call to
 IS_ERR that is wrong.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

Fixes: 82d4ff586ae2 ("PM / devfreq: Add cpu based scaling support to passive governor")
CC: Saravana Kannan <skannan@...eaurora.org>
Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: kernel test robot <lkp@...el.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git devfreq-testing-passive-gov
head:   82d4ff586ae2fb6d89cad871949004bed3438ccb
commit: 82d4ff586ae2fb6d89cad871949004bed3438ccb [3/3] PM / devfreq: Add cpu based scaling support to passive governor
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

Please take the patch only if it's a positive warning. Thanks!

 governor_passive.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/devfreq/governor_passive.c
+++ b/drivers/devfreq/governor_passive.c
@@ -316,7 +316,7 @@ static int cpufreq_passive_register(stru

 			opp_table = dev_pm_opp_get_opp_table(cpu_dev);
 			if (IS_ERR(devfreq->opp_table)) {
-				ret = PTR_ERR(opp_table);
+				ret = PTR_ERR(devfreq->opp_table);
 				goto out;
 			}