[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <OSAPR01MB2737C9B5A781E7F7134D7038C29A9@OSAPR01MB2737.jpnprd01.prod.outlook.com>
Date: Mon, 1 Mar 2021 15:13:24 +0000
From: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC: Rob Herring <robh+dt@...nel.org>, Arnd Bergmann <arnd@...db.de>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"linux-renesas-soc@...r.kernel.org"
<linux-renesas-soc@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Chris Paterson <Chris.Paterson2@...esas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
Phil Edworthy <phil.edworthy@...esas.com>,
"REE dirk.behme@...bosch.com" <dirk.behme@...bosch.com>,
Peter Erben <Peter.Erben@...bosch.com>
Subject: RE: [PATCH 3/7] dt-bindings: misc: Add binding for R-Car DAB
Hi Laurent,
Thanks for your feedback!
> From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Sent: 26 February 2021 13:02
> Subject: Re: [PATCH 3/7] dt-bindings: misc: Add binding for R-Car DAB
>
> Hi Fabrizio,
>
> Thank you for the patch.
>
> On Thu, Feb 25, 2021 at 10:51:43PM +0000, Fabrizio Castro wrote:
> > Document bindings for R-Car DAB hardware accelerator, currently
> > found on the r8a77990 SoC (a.k.a. R-Car E3) and on the r8a77965
> > SoC (a.k.a. R-Car M3-N).
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
> > ---
> > .../devicetree/bindings/misc/renesas,dab.yaml | 75 +++++++++++++++++++
> > 1 file changed, 75 insertions(+)
> > create mode 100644
> Documentation/devicetree/bindings/misc/renesas,dab.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/misc/renesas,dab.yaml
> b/Documentation/devicetree/bindings/misc/renesas,dab.yaml
> > new file mode 100644
> > index 000000000000..e9494add13d7
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/renesas,dab.yaml
> > @@ -0,0 +1,75 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright (C) 2021 Renesas Electronics Corporation
> > +%YAML 1.2
> > +---
> > +$id:
> https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetre
> e.org%2Fschemas%2Fmisc%2Frenesas%2Cdab.yaml%23&data=04%7C01%7Cfabrizio
> .castro.jz%40renesas.com%7Cb383aa9cfef34b6653e008d8da56c204%7C53d82571da19
> 47e49cb4625a166a4a2a%7C0%7C0%7C637499413468300421%7CUnknown%7CTWFpbGZsb3d8
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&
> amp;sdata=r95fhwTCpf0gkNoRtCLrUbZtaCbI3da9sbFLv0UXipE%3D&reserved=0
> > +$schema:
> https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetre
> e.org%2Fmeta-
> schemas%2Fcore.yaml%23&data=04%7C01%7Cfabrizio.castro.jz%40renesas.com
> %7Cb383aa9cfef34b6653e008d8da56c204%7C53d82571da1947e49cb4625a166a4a2a%7C0
> %7C0%7C637499413468300421%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ
> IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ajJ%2BmBs4zOzK
> cJghYY89B6PMgrxRFgoVVuflZCFmHYc%3D&reserved=0
> > +
> > +title: Renesas R-Car DAB Hardware Accelerator
> > +
> > +maintainers:
> > + - Fabrizio Castro <fabrizio.castro.jz@...esas.com>
> > +
> > +description:
> > + The DAB hardware accelerator found on some R-Car devices is a
> hardware
> > + accelerator for software DAB demodulators.
> > + It consists of one FFT (Fast Fourier Transform) module and one
> decoder module,
> > + compatible with DAB specification (ETSI EN 300 401 and ETSI TS 102
> 563).
> > + The decoder module can perform FIC decoding and MSC decoding
> processing from
> > + de-puncture to final decoded result.
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - renesas,dab-r8a77965 # R-Car M3-N
> > + - renesas,dab-r8a77990 # R-Car E3
> > + - const: renesas,rcar-gen3-dab # Generic fallback for R-Car Gen3
> devices
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
>
> I usually try to describe clocks:
>
> clocks:
> items:
> - description: The module functional clock
>
> but as there's a single clock, it may not be worth it. Up to you.
Will change as per your suggestion.
Thanks,
Fab
>
> > +
> > + clock-names:
> > + const: dab
>
> With Geert's and Sergei's comments addressed,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + resets:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > + - clock-names
> > + - power-domains
> > + - resets
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + # R8A77990 (R-Car E3)
> > + - |
> > + #include <dt-bindings/clock/r8a77990-cpg-mssr.h>
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/power/r8a77990-sysc.h>
> > +
> > + dab: dab@...30000 {
> > + compatible = "renesas,dab-r8a77990",
> > + "renesas,rcar-gen3-dab";
> > + reg = <0xe6730000 0x120>;
> > + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 1016>;
> > + clock-names = "dab";
> > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
> > + resets = <&cpg 1016>;
> > + status = "disabled";
> > + };
>
> --
> Regards,
>
> Laurent Pinchart
Powered by blists - more mailing lists