linux-kernel - Re: [PATCH] tpm: Remove unintentional dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YD1X553fpbyl7Kbw@rikard>
Date:   Mon, 1 Mar 2021 22:08:55 +0100
From:   Rikard Falkeborn <rikard.falkeborn@...il.com>
To:     jarkko@...nel.org
Cc:     linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH] tpm: Remove unintentional dump_stack() call

On Mon, Mar 01, 2021 at 11:44:09AM +0200, jarkko@...nel.org wrote:
> From: Jarkko Sakkinen <jarkko@...nel.org>
> 
> Somewhere along the line, probably during a rebase, an unintentional
> dump_stack() got included. Revert this change.
> 
> Reported-by: Rikard Falkeborn <rikard.falkeborn@...il.com>
> Fixes: 90cba8d20f8b ("tpm/ppi: Constify static struct attribute_group")
> Signed-off-by: Jarkko Sakkinen <jarkko@...nel.org>
> ---
>  drivers/char/tpm/tpm-chip.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
> index 19e23fcc6bc8..ddaeceb7e109 100644
> --- a/drivers/char/tpm/tpm-chip.c
> +++ b/drivers/char/tpm/tpm-chip.c
> @@ -278,8 +278,6 @@ static void tpm_devs_release(struct device *dev)
>  {
>  	struct tpm_chip *chip = container_of(dev, struct tpm_chip, devs);
>  
> -	dump_stack();
> -
>  	/* release the master device reference */
>  	put_device(&chip->dev);
>  }
> -- 
> 2.30.1
> 

Acked-by: Rikard Falkeborn <rikard.falkeborn@...il.com>