linux-kernel - Re: [PATCH v1] microblaze: tag highmem_setup() with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210301221846.GA4744@localhost.localdomain>
Date:   Mon, 1 Mar 2021 23:18:46 +0100
From:   Oscar Salvador <osalvador@...e.de>
To:     David Hildenbrand <david@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        kernel test robot <lkp@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michal Simek <monstr@...str.eu>,
        Mike Rapoport <rppt@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Arvind Sankar <nivedita@...m.mit.edu>,
        Ira Weiny <ira.weiny@...el.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Anshuman Khandual <anshuman.khandual@....com>
Subject: Re: [PATCH v1] microblaze: tag highmem_setup() with __meminit

On Mon, Mar 01, 2021 at 12:47:49PM +0100, David Hildenbrand wrote:
> With commit a0cd7a7c4bc0 ("mm: simplify free_highmem_page() and
> free_reserved_page()") the kernel test robot complains about a warning:
> 
> WARNING: modpost: vmlinux.o(.text.unlikely+0x23ac): Section mismatch in
>   reference from the function highmem_setup() to the function
>   .meminit.text:memblock_is_reserved()
> 
> This has been broken ever since microblaze added highmem support,
> because memblock_is_reserved() was already tagged with "__init" back then -
> most probably the function always got inlined, so we never stumbled over
> it.

It might be good to point out that we need __meminit instead of __init
because microblaze platform does not define CONFIG_ARCH_KEEP_MEMBLOCK,
and __init_memblock fallsback to that.

(I had to go and look as I was puzzled :-) )

Reviewed-by: Oscar Salvador <osalvador@...e.de>

> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 2f2f371f8907 ("microblaze: Highmem support")
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Michal Simek <monstr@...str.eu>
> Cc: Mike Rapoport <rppt@...nel.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Arvind Sankar <nivedita@...m.mit.edu>
> Cc: Ira Weiny <ira.weiny@...el.com>
> Cc: Randy Dunlap <rdunlap@...radead.org>
> Cc: Oscar Salvador <osalvador@...e.de>
> Cc: Anshuman Khandual <anshuman.khandual@....com>
> Signed-off-by: David Hildenbrand <david@...hat.com>
> ---
>  arch/microblaze/mm/init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
> index 181e48782e6c..05cf1fb3f5ff 100644
> --- a/arch/microblaze/mm/init.c
> +++ b/arch/microblaze/mm/init.c
> @@ -52,7 +52,7 @@ static void __init highmem_init(void)
>  	pkmap_page_table = virt_to_kpte(PKMAP_BASE);
>  }
>  
> -static void highmem_setup(void)
> +static void __meminit highmem_setup(void)
>  {
>  	unsigned long pfn;
>  
> -- 
> 2.29.2
> 
> 

-- 
Oscar Salvador
SUSE L3