linux-kernel - Re: [PATCH] spi: rockchip: avoid objtool warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <161464187231.31555.17379793263807156995.b4-ty@kernel.org>
Date:   Mon, 01 Mar 2021 23:37:52 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Nick Desaulniers <ndesaulniers@...gle.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Arnd Bergmann <arnd@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Emil Renner Berthing <kernel@...il.dk>
Cc:     linux-rockchip@...ts.infradead.org,
        Alexander Kochetkov <al.kochet@...il.com>,
        Jon Lin <jon.lin@...k-chips.com>,
        Chris Ruehl <chris.ruehl@...ys.com.hk>,
        Johan Jonker <jbx6244@...il.com>, linux-kernel@...r.kernel.org,
        clang-built-linux@...glegroups.com, linux-spi@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>,
        Vincent Pelletier <plr.vincent@...il.com>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] spi: rockchip: avoid objtool warning

On Thu, 25 Feb 2021 13:55:34 +0100, Arnd Bergmann wrote:
> Building this file with clang leads to a an unreachable code path
> causing a warning from objtool:
> 
> drivers/spi/spi-rockchip.o: warning: objtool: rockchip_spi_transfer_one()+0x2e0: sibling call from callable instruction with modified stack frame
> 
> Use BUG() instead of unreachable() to avoid the undefined behavior
> if it does happen.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: rockchip: avoid objtool warning
      commit: d86e880f7a7c5b64a650146a1353f98750863f21

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark