linux-kernel - RE: [PATCH] exfat: fix erroneous discard when clear cluster bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000001d70f0d$8e882ec0$ab988c40$@samsung.com>
Date:   Tue, 2 Mar 2021 11:41:33 +0900
From:   "Sungjong Seo" <sj1557.seo@...sung.com>
To:     "'Hyeongseok Kim'" <hyeongseok@...il.com>,
        <namjae.jeon@...sung.com>
Cc:     <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <sj1557.seo@...sung.com>
Subject: RE: [PATCH] exfat: fix erroneous discard when clear cluster bit

> Subject: [PATCH] exfat: fix erroneous discard when clear cluster bit
> 
> If mounted with discard option, exFAT issues discard command when clear
> cluster bit to remove file. But the input parameter of cluster-to-sector
> calculation is abnormally adds reserved cluster size which is 2, leading
> to discard unrelated sectors included in target+2 cluster.
> 
> Fixes: 1e49a94cf707 ("exfat: add bitmap operations")
> Signed-off-by: Hyeongseok Kim <hyeongseok@...il.com>
> ---
>  fs/exfat/balloc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Looks good.

Acked-by: Sungjong Seo <sj1557.seo@...sung.com>

Thanks for your work!
Could you remove the wrong comments above set/clear/find bitmap functions
together?