linux-kernel - Re: [PATCH] w1: ds2708 and ds2781 use the new API kobj_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YD3atYZfpTh0XliL@kroah.com>
Date:   Tue, 2 Mar 2021 07:27:01 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tian Tao <tiantao6@...ilicon.com>
Cc:     rikard.falkeborn@...il.com, zbr@...emap.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] w1: ds2708 and ds2781 use the new API kobj_to_dev()

On Tue, Mar 02, 2021 at 02:17:02PM +0800, Tian Tao wrote:
> fix the below warnning which reported by coccicheck.
> /drivers/w1/slaves/w1_ds2780.c:93:60-61: WARNING opportunity for
> kobj_to_dev().
> /drivers/w1/slaves/w1_ds2781.c:90:60-61: WARNING opportunity for
> kobj_to_dev().
> 
> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>
> ---
>  drivers/w1/slaves/w1_ds2780.c | 2 +-
>  drivers/w1/slaves/w1_ds2781.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/w1/slaves/w1_ds2780.c b/drivers/w1/slaves/w1_ds2780.c
> index c281fe5..9dcb5a5 100644
> --- a/drivers/w1/slaves/w1_ds2780.c
> +++ b/drivers/w1/slaves/w1_ds2780.c
> @@ -90,7 +90,7 @@ static ssize_t w1_slave_read(struct file *filp, struct kobject *kobj,
>  			     struct bin_attribute *bin_attr, char *buf,
>  			     loff_t off, size_t count)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	return w1_ds2780_io(dev, buf, off, count, 0);
>  }
>  
> diff --git a/drivers/w1/slaves/w1_ds2781.c b/drivers/w1/slaves/w1_ds2781.c
> index f0d393a..2cb7c02 100644
> --- a/drivers/w1/slaves/w1_ds2781.c
> +++ b/drivers/w1/slaves/w1_ds2781.c
> @@ -87,7 +87,7 @@ static ssize_t w1_slave_read(struct file *filp, struct kobject *kobj,
>  			     struct bin_attribute *bin_attr, char *buf,
>  			     loff_t off, size_t count)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	return w1_ds2781_io(dev, buf, off, count, 0);
>  }
>  
> -- 
> 2.7.4
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot