linux-kernel - Re: [PATCH v3 6/8] mm: Selftests for exclusive device memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4866160.ulnvbvOQiP@nvdebian>
Date:   Tue, 2 Mar 2021 20:12:24 +1100
From:   Alistair Popple <apopple@...dia.com>
To:     Ralph Campbell <rcampbell@...dia.com>
CC:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
        "bskeggs@...hat.com" <bskeggs@...hat.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "John Hubbard" <jhubbard@...dia.com>,
        "jglisse@...hat.com" <jglisse@...hat.com>,
        Jason Gunthorpe <jgg@...dia.com>,
        "hch@...radead.org" <hch@...radead.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>
Subject: Re: [PATCH v3 6/8] mm: Selftests for exclusive device memory

On Tuesday, 2 March 2021 10:14:56 AM AEDT Ralph Campbell wrote:
> > From: Alistair Popple <apopple@...dia.com>
> > Sent: Thursday, February 25, 2021 11:19 PM
> > To: linux-mm@...ck.org; nouveau@...ts.freedesktop.org;
> > bskeggs@...hat.com; akpm@...ux-foundation.org
> > Cc: linux-doc@...r.kernel.org; linux-kernel@...r.kernel.org; dri-
> > devel@...ts.freedesktop.org; John Hubbard <jhubbard@...dia.com>; Ralph
> > Campbell <rcampbell@...dia.com>; jglisse@...hat.com; Jason Gunthorpe
> > <jgg@...dia.com>; hch@...radead.org; daniel@...ll.ch; Alistair Popple
> > <apopple@...dia.com>
> > Subject: [PATCH v3 6/8] mm: Selftests for exclusive device memory
> > 
> > Adds some selftests for exclusive device memory.
> > 
> > Signed-off-by: Alistair Popple <apopple@...dia.com>
> 
> One minor nit below, but you can add

Thanks Ralph. Will fix that.

> Tested-by: Ralph Campbell <rcampbell@...dia.com>
> Reviewed-by: Ralph Campbell <rcampbell@...dia.com>
> 
> > +static int dmirror_exclusive(struct dmirror *dmirror,
> > +			     struct hmm_dmirror_cmd *cmd)
> > +{
> > +	unsigned long start, end, addr;
> > +	unsigned long size = cmd->npages << PAGE_SHIFT;
> > +	struct mm_struct *mm = dmirror->notifier.mm;
> > +	struct page *pages[64];
> > +	struct dmirror_bounce bounce;
> > +	unsigned long next;
> > +	int ret;
> > +
> > +	start = cmd->addr;
> > +	end = start + size;
> > +	if (end < start)
> > +		return -EINVAL;
> > +
> > +	/* Since the mm is for the mirrored process, get a reference first. */
> > +	if (!mmget_not_zero(mm))
> > +		return -EINVAL;
> > +
> > +	mmap_read_lock(mm);
> > +	for (addr = start; addr < end; addr = next) {
> > +		int i, mapped;
> > +
> > +		if (end < addr + (64 << PAGE_SHIFT))
> > +			next = end;
> > +		else
> > +			next = addr + (64 << PAGE_SHIFT);
> 
> I suggest using ARRAY_SIZE(pages) instead of '64' to make the meaning clear.
> 
>