linux-kernel - Re: [PATCH v7 0/2] ARM: Implement MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <950ee6f5-13f2-8a07-6956-6921df4fc435@nokia.com>
Date:   Tue, 2 Mar 2021 11:00:51 +0100
From:   Alexander Sverdlin <alexander.sverdlin@...ia.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Ard Biesheuvel <ardb@...nel.org>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Russell King <linux@...linux.org.uk>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 0/2] ARM: Implement MODULE_PLT support in FTRACE

Hello Linus,

On 02/03/2021 09:29, Linus Walleij wrote:
>>>> FTRACE's function tracer currently doesn't always work on ARM with
>>>> MODULE_PLT option enabled. If the module is loaded too far, FTRACE's

First of all:

config ARM_MODULE_PLTS                                                                                                                                                                                             
        bool "Use PLTs to allow module memory to spill over into vmalloc area"                                                                                                                                     


[...]

> Any suggestions on a quick use case that illustrates how the problem
> manifest and how to test it is gone? The errors in patch 2, what do
> I need to configure in to get them? Does it manifest at modprobe?

And then I use this module to test for the problem:

/**********************************************************************
 * Author: Alexander Sverdlin <alexander.sverdlin@...ia.com>
 *
 * Copyright (c) 2018 Nokia
 *
 * SPDX-License-Identifier: GPL-2.0
 *
 * This module is intended to test ARM MODULE_PLT functionality
 **********************************************************************/

#include <linux/types.h>
#include <linux/kernel.h>
#include <linux/module.h>

static int fatmod_init(void)
{
	asm volatile (".rept (6 * 1024 * 1024 / 2)\n\t"
		      "nop\n\t"
		      ".endr");
	return 0;
}
module_init(fatmod_init);

static void __exit fatmod_exit(void)
{
}
module_exit(fatmod_exit);

MODULE_AUTHOR("Alexander Sverdlin <alexander.sverdlin@...ia.com>");
MODULE_DESCRIPTION("ARM MODULE_PLT test module");
MODULE_LICENSE("GPL");

-- 
Best regards,
Alexander Sverdlin.